Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix process not exiting calling .close() right after watching. #600

Merged
merged 3 commits into from
May 2, 2017
Merged

Fix process not exiting calling .close() right after watching. #600

merged 3 commits into from
May 2, 2017

Conversation

satazor
Copy link
Contributor

@satazor satazor commented Apr 29, 2017

Attempts to fix #434

@es128 can you review this when you got some time?

Cheers

@coveralls
Copy link

coveralls commented Apr 29, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 98.397% when pulling 44a4d94 on satazor:master into f03f332 on paulmillr:master.

@satazor
Copy link
Contributor Author

satazor commented Apr 29, 2017 •
edited
Loading

Strange.. tests pass on my macOS machine but some are failing on travis.

@es128
Copy link
Collaborator

es128 commented Apr 29, 2017

The Travis OS X failures may be unrelated, it's always a struggle with those.

But please do try to figure out the issue on Linux. The nodefs side of this patch may not be working the way you've intended.

@satazor
Copy link
Contributor Author

satazor commented Apr 29, 2017

Actually the test I've added is passing on all macOSx @ travis but are failing on linux. Will spawn my linux vm and investigate.

@coveralls
Copy link

coveralls commented Apr 29, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 98.397% when pulling 18b0ade on satazor:master into f03f332 on paulmillr:master.

@satazor
Copy link
Contributor Author

satazor commented Apr 29, 2017 •
edited
Loading

@es128 Should be good now. Some unrelated tests sometimes fail, sometimes they pass.
Let me know what you think.

@coveralls
Copy link

coveralls commented Apr 29, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.009%) to 98.447% when pulling 3b296d3 on satazor:master into f03f332 on paulmillr:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 98.447% when pulling 3b296d3 on satazor:master into f03f332 on paulmillr:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 98.447% when pulling 3b296d3 on satazor:master into f03f332 on paulmillr:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 98.447% when pulling 3b296d3 on satazor:master into f03f332 on paulmillr:master.

@coveralls
Copy link

coveralls commented Apr 29, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.009%) to 98.447% when pulling f1d4b61 on satazor:master into f03f332 on paulmillr:master.

@satazor
Copy link
Contributor Author

satazor commented May 2, 2017

@es128 Did you find the time to check this PR?

@es128
Copy link
Collaborator

es128 commented May 2, 2017

Just wanted to see the new test pass in appveyor.

Looks good, thanks!

@es128 es128 merged commit c716ffd into paulmillr:master May 2, 2017
@es128 es128 mentioned this pull request May 2, 2017
Closed
@satazor
Copy link
Contributor Author

satazor commented May 2, 2017

@edi9999 Cool! Shall we expect a new release soon?

@edi9999
Copy link
Contributor

edi9999 commented May 3, 2017 •
edited
Loading

You probably meant @es128 ?

@satazor
Copy link
Contributor Author

satazor commented May 3, 2017

Oh yea sorry :p

@satazor
Copy link
Contributor Author

satazor commented May 6, 2017

@es128 Bump :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node doesn't exit after closing watch
4 participants
@satazor @coveralls @es128 @edi9999